linux-kernel - Re: [usb:usb-next 50/92] drivers/usb/serial/pl2303.c:149 pl2303_vendor_read() error: doing dma on the stack (buf)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140104173222.GE5443@mwanda>
Date:	Sat, 4 Jan 2014 20:32:22 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Johan Hovold <jhovold@...il.com>
Cc:	kbuild test robot <fengguang.wu@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	kbuild-all@...org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [usb:usb-next 50/92] drivers/usb/serial/pl2303.c:149
 pl2303_vendor_read() error: doing dma on the stack (buf)

On Sat, Jan 04, 2014 at 12:23:41PM +0100, Johan Hovold wrote:
> On Sat, Jan 04, 2014 at 05:28:35AM +0800, kbuild test robot wrote:
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
> > head:   bd6383c81d5f33e01688a87c50a8d3a878aa43d5
> > commit: 362eb02603be7bb835c47f2cf585954a5080449d [50/92] USB: pl2303: add error handling to vendor read and write functions
> > 
> > New smatch warnings:
> > drivers/usb/serial/pl2303.c:149 pl2303_vendor_read() error: doing dma on the stack (buf)
> >
> > Old smatch warnings:
> > drivers/usb/serial/pl2303.c:673 pl2303_ioctl() warn: check that 'ser' doesn't leak information (struct has a hole after 'iomem_reg_shift')
> > 
> > vim +149 drivers/usb/serial/pl2303.c
> > 
> > 8bf769eb Johan Hovold   2012-10-15  133  };
> > 8bf769eb Johan Hovold   2012-10-15  134  
> > ^1da177e Linus Torvalds 2005-04-16  135  struct pl2303_private {
> > ^1da177e Linus Torvalds 2005-04-16  136  	spinlock_t lock;
> > ^1da177e Linus Torvalds 2005-04-16  137  	u8 line_control;
> > ^1da177e Linus Torvalds 2005-04-16  138  	u8 line_status;
> > 623c8263 Johan Hovold   2013-12-29  139  
> > 623c8263 Johan Hovold   2013-12-29  140  	u8 line_settings[7];
> > ^1da177e Linus Torvalds 2005-04-16  141  };
> > ^1da177e Linus Torvalds 2005-04-16  142  
> > 362eb026 Johan Hovold   2013-12-29  143  static int pl2303_vendor_read(struct usb_serial *serial, u16 value,
> > 362eb026 Johan Hovold   2013-12-29  144  							unsigned char buf[1])
> 
> This is a false positive. A pointer passed as an array is still just a
> pointer (and in this case the buffer it points to is not on the stack).
> 
> Looks like smatch needs to be updated.
> 

Thanks.  I have written a fix for this and will push next week.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/