linux-kernel - Re: [PATCH] Input: ims-pcu - fix error unwinding path in application mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQ1cqGZT7TOCX+5yPhWt1MpsSbAfbr07SProgSxrn7RO=7aig@mail.gmail.com>
Date:	Fri, 3 Jan 2014 21:13:10 -0800
From:	Andrey Smirnov <andrew.smirnov@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, Chris Healy <chealy@...co-us.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: ims-pcu - fix error unwinding path in application mode

Dmitry,

Do you want this patch to go separatly or do you want me to bundle it
with my other changes(probably the first one)?
Also, offtopic, do you want me to backport this changes to 2.6 kernel
that IMS uses or would you do it?

Thanks,

On Fri, Jan 3, 2014 at 9:00 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> We first create backlight and then input devices so we shoudl destroy them
> in opposite order when handling errors.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>
> Andrey, this fixup was split off from the patch I sent earlier today.
>
>  drivers/input/misc/ims-pcu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
> index 4244f47..513ecdf 100644
> --- a/drivers/input/misc/ims-pcu.c
> +++ b/drivers/input/misc/ims-pcu.c
> @@ -1929,10 +1929,10 @@ static int ims_pcu_init_application_mode(struct ims_pcu *pcu)
>
>         return 0;
>
> -err_destroy_backlight:
> -       ims_pcu_destroy_backlight(pcu);
>  err_destroy_buttons:
>         ims_pcu_destroy_buttons(pcu);
> +err_destroy_backlight:
> +       ims_pcu_destroy_backlight(pcu);
>         return error;
>  }
>
> --
> 1.8.4.2
>
>
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/