| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1388887680-942-1-git-send-email-ethan.kernel@gmail.com> Date: Sun, 5 Jan 2014 10:08:00 +0800 From: Ethan Zhao <ethan.kernel@...il.com> To: hans.verkuil@...co.com, m.chehab@...sung.com, gregkh@...uxfoundation.org, mchehab@...hat.com Cc: linux-kernel@...r.kernel.org, Ethan Zhao <ethan.kernel@...il.com> Subject: [PATCH] [media] saa7146: fix a possible NULL pointer reference in saa7146_set_position Function saa7146_format_by_fourcc() may return NULL, reference of the returned result would cause NULL pointer issue without checking. Signed-off-by: Ethan Zhao <ethan.kernel@...il.com> --- drivers/media/common/saa7146/saa7146_hlp.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/media/common/saa7146/saa7146_hlp.c b/drivers/media/common/saa7146/saa7146_hlp.c index be746d1..3e23eab 100644 --- a/drivers/media/common/saa7146/saa7146_hlp.c +++ b/drivers/media/common/saa7146/saa7146_hlp.c @@ -575,6 +575,7 @@ static void saa7146_set_position(struct saa7146_dev *dev, int w_x, int w_y, int */ u32 base = (u32)(unsigned long)vv->ov_fb.base; + int which = 1; struct saa7146_video_dma vdma1; /* calculate memory offsets for picture, look if we shall top-down-flip */ @@ -608,10 +609,14 @@ static void saa7146_set_position(struct saa7146_dev *dev, int w_x, int w_y, int vdma1.pitch *= -1; } - vdma1.base_page = sfmt->swap; + if (sfmt) + vdma1.base_page = sfmt->swap; + else + which = 0; + vdma1.num_line_byte = (vv->standard->v_field<<16)+vv->standard->h_pixels; - saa7146_write_out_dma(dev, 1, &vdma1); + saa7146_write_out_dma(dev, which, &vdma1); } static void saa7146_set_output_format(struct saa7146_dev *dev, unsigned long palette) -- 1.8.3.4 (Apple Git-47) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists