lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 06 Jan 2014 00:33:57 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org, josh@...htriplett.org
Subject: Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote:
> Include header file internal.h in debugfs.c and change the return
> value's type in header file internal.h.
> 
> This eliminates the following warning in debugfs.c:
> drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
> ---
>  drivers/acpi/debugfs.c  |    3 +++
>  drivers/acpi/internal.h |    2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
> index b55d6a2..96bcaf7 100644
> --- a/drivers/acpi/debugfs.c
> +++ b/drivers/acpi/debugfs.c
> @@ -6,6 +6,7 @@
>  #include <linux/init.h>
>  #include <linux/debugfs.h>
>  #include <acpi/acpi_drivers.h>
> +#include "internal.h"
>  
>  #define _COMPONENT		ACPI_SYSTEM_COMPONENT
>  ACPI_MODULE_NAME("debugfs");
> @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
>  struct dentry *acpi_debugfs_dir;
>  EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
>  
> +#ifdef  CONFIG_DEBUG_FS
>  void __init acpi_debugfs_init(void)
>  {
>  	acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
>  }
> +#endif

What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset?

That surely would make sense? 

> diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
> index 8ef9787..c2e35bd 100644
> --- a/drivers/acpi/internal.h
> +++ b/drivers/acpi/internal.h
> @@ -63,7 +63,7 @@ void acpi_scan_hotplug_enabled(struct acpi_hotplug_profile *hotplug, bool val);
>  
>  #ifdef CONFIG_DEBUG_FS
>  extern struct dentry *acpi_debugfs_dir;
> -int acpi_debugfs_init(void);
> +void acpi_debugfs_init(void);
>  #else
>  static inline void acpi_debugfs_init(void) { return; }
>  #endif
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists