linux-kernel - [pipe] b8597fdc23: -8% regression of hackbench throughput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140105044648.GA28257@localhost>
Date:	Sun, 5 Jan 2014 12:46:48 +0800
From:	fengguang.wu@...el.com
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	lkp@...ux.intel.com
Subject: [pipe] b8597fdc23: -8% regression of hackbench throughput

Hi Dmitry,

We measured some 8% drop of hackbench throughput with your small commit
b8597fdc23 ("fs/pipe.c: skip file_update_time on frozen fs"). Comparing to its
parent commit, we also see increased context switches:

5b6e04beb19abc9  b8597fdc23f8f6e26a531e9a7  
---------------  -------------------------  
    231874 ~ 1%      -7.3%     214834 ~ 2%  lkp-snb01/micro/hackbench/1600%-process-pipe
     87774 ~ 3%     -10.7%      78419 ~ 4%  xps2/micro/hackbench/1600%-process-pipe
    319649           -8.3%     293253       TOTAL hackbench.throughput

5b6e04beb19abc9  b8597fdc23f8f6e26a531e9a7  
---------------  -------------------------  
   3673577 ~ 1%     +17.4%    4312376 ~ 2%  lkp-snb01/micro/hackbench/1600%-process-pipe
    195669 ~ 3%    +156.6%     502173 ~ 4%  xps2/micro/hackbench/1600%-process-pipe
   3869246          +24.4%    4814550       TOTAL vmstat.system.cs

5b6e04beb19abc9  b8597fdc23f8f6e26a531e9a7  
---------------  -------------------------  
 6.311e+08 ~ 2%     +33.7%  8.437e+08 ~ 1%  lkp-snb01/micro/hackbench/1600%-process-pipe
  21485632 ~ 3%    +411.9%    1.1e+08 ~ 8%  xps2/micro/hackbench/1600%-process-pipe
 6.526e+08          +46.1%  9.537e+08       TOTAL time.involuntary_context_switches

5b6e04beb19abc9  b8597fdc23f8f6e26a531e9a7  
---------------  -------------------------  
 1.563e+09 ~ 2%     +12.8%  1.763e+09 ~ 3%  lkp-snb01/micro/hackbench/1600%-process-pipe
  96703947 ~ 3%    +102.7%   1.96e+08 ~ 3%  xps2/micro/hackbench/1600%-process-pipe
  1.66e+09          +18.0%  1.959e+09       TOTAL time.voluntary_context_switches

The bisect looks stable:

                           time.involuntary_context_switches

     9e+08 ++---------------------------------------------------------------+
           |                                  O                             |
   8.5e+08 O+O O O O                   O    O     O O O                     |
           |         O O O O O O O   O   O      O                           |
     8e+08 ++                      O                                        |
           |                                                                |
   7.5e+08 ++                                                               |
           |                                                                |
     7e+08 ++                                                               |
           |.*   *.*.*.*.*   *.                  .*   *.                    |
   6.5e+08 *+ + +         + +  *.*.*.*       .*.*  + +  *.    *.   .*   *.  |
           |   *           *          + .*..*       *     *. +  *.*  + +  *.*
     6e+08 ++                          *                    *         *     |
           |                                                                |
   5.5e+08 ++---------------------------------------------------------------+

Thanks,
Fengguang

View attachment "0001-fs-pipe.c-skip-file_update_time-on-frozen-fs.patch" of type "text/x-diff" (1217 bytes)