linux-kernel - [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error in rtllib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun,  5 Jan 2014 13:25:36 +0100
From:	Andreas Frembs <andreas.frembs@...dium.uni-erlangen.de>
To:	andreas.frembs@...dium.uni-erlangen.de
Cc:	matthias.schoepe@...dium.uni-erlangen.de,
	linux-kernel@...cs.fau.de, gregkh@...uxfoundation.org,
	dhowells@...hat.com, viro@...iv.linux.org.uk,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	linville@...driver.com, andrea.merello@...il.com,
	valentina.manea.m@...il.com, lisa@...apiadmin.com
Subject: [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error in rtllib_debug.h

In rtllib_debug.h we fixed the following checkpatch error:
	ERROR: Macros with complex values should be enclosed in parenthesis

We fixed this with a do {} while (0), because otherwise the compiler complained.

Signed-off-by: Andreas Frembs <andreas.frembs@...dium.uni-erlangen.de>
Signed-off-by: Matthias Schoepe <matthias.schoepe@...dium.uni-erlangen.de>
---
 drivers/staging/rtl8192e/rtllib_debug.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_debug.h b/drivers/staging/rtl8192e/rtllib_debug.h
index c59f67b..31f616f 100644
--- a/drivers/staging/rtl8192e/rtllib_debug.h
+++ b/drivers/staging/rtl8192e/rtllib_debug.h
@@ -78,9 +78,11 @@ do {			\
 } while (0);
 
 #define assert(expr) \
+do {	\
 	if (!(expr)) {				  \
 		printk(KERN_INFO "Assertion failed! %s,%s,%s,line=%d\n", \
 		#expr, __FILE__, __func__, __LINE__);	  \
-	}
+	}	\
+} while (0);
 
 #endif
-- 
1.8.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/