lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 5 Jan 2014 17:58:31 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Arun Sharma <asharma@...com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Rodrigo Campos <rodrigo@...g.com.ar>
Subject: Re: [PATCH 05/21] perf hists: Accumulate hist entry stat based on
 the callchain

On Tue, Dec 24, 2013 at 05:22:11PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@....com>
> 
> Call __hists__add_entry() for each callchain node to get an
> accumulated stat for an entry.  Introduce new cumulative_iter ops to
> process them properly.
> 
> Cc: Arun Sharma <asharma@...com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/builtin-report.c | 103 +++++++++++++++++++++++++++++++++++++++++++-
>  tools/perf/ui/stdio/hist.c  |   2 +-
>  2 files changed, 103 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 29fe19071d24..4fde0ab82498 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -360,6 +360,97 @@ iter_finish_normal_entry(struct add_entry_iter *iter, struct addr_location *al)
>  	return hist_entry__append_callchain(he, sample);
>  }
>  
> +static int
> +iter_prepare_cumulative_entry(struct add_entry_iter *iter,
> +			      struct machine *machine __maybe_unused,
> +			      struct perf_evsel *evsel,
> +			      struct addr_location *al __maybe_unused,
> +			      struct perf_sample *sample)
> +{
> +	callchain_cursor_commit(&callchain_cursor);
> +
> +	iter->evsel = evsel;
> +	iter->sample = sample;
> +	return 0;
> +}
> +
> +static int
> +iter_add_single_cumulative_entry(struct add_entry_iter *iter,
> +				 struct addr_location *al)
> +{
> +	struct perf_evsel *evsel = iter->evsel;
> +	struct perf_sample *sample = iter->sample;
> +	struct hist_entry *he;
> +
> +	he = __hists__add_entry(&evsel->hists, al, iter->parent, NULL, NULL,
> +				sample->period, sample->weight,
> +				sample->transaction, true);
> +	if (he == NULL)
> +		return -ENOMEM;
> +
> +	/*
> +	 * This is for putting parents upward during output resort iff
> +	 * only a child gets sampled.  See hist_entry__sort_on_period().
> +	 */
> +	he->callchain->max_depth = PERF_MAX_STACK_DEPTH + 1;

so you're using callchain struct to hold the entry's stack
position for sorting.. I think we could store this info
inside hist_entry itself, and omit 'struct callchain_root'
size being allocated for hist_entry

I checked 'struct hist_entry' and the 'position' entry seems to
be abandonned ;-)) or we could use some unused entry (mem_info?)
and create some union.

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists