linux-kernel - Re: [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error in rtllib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140106080520.GK30234@mwanda>
Date:	Mon, 6 Jan 2014 11:05:20 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Andreas Frembs <andreas.frembs@...dium.uni-erlangen.de>
Cc:	devel@...verdev.osuosl.org, lisa@...apiadmin.com,
	linux-kernel@...cs.fau.de, andrea.merello@...il.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	matthias.schoepe@...dium.uni-erlangen.de, dhowells@...hat.com,
	valentina.manea.m@...il.com, viro@...iv.linux.org.uk,
	linville@...driver.com
Subject: Re: [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error in
 rtllib_debug.h

On Sun, Jan 05, 2014 at 01:25:36PM +0100, Andreas Frembs wrote:
> In rtllib_debug.h we fixed the following checkpatch error:
> 	ERROR: Macros with complex values should be enclosed in parenthesis
> 
> We fixed this with a do {} while (0), because otherwise the compiler complained.
> 
> Signed-off-by: Andreas Frembs <andreas.frembs@...dium.uni-erlangen.de>
> Signed-off-by: Matthias Schoepe <matthias.schoepe@...dium.uni-erlangen.de>

It would be better to replace these with WARN_ON().  I haven't looked
but I also suspect that some of these asserts might be bogus and should
be removed.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/