linux-kernel - Re: [PATCH 06/21] perf tools: Update cpumode for each cumulative entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877gaded5f.fsf@sejong.aot.lge.com>
Date:	Mon, 06 Jan 2014 17:18:52 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Arun Sharma <asharma@...com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Rodrigo Campos <rodrigo@...g.com.ar>
Subject: Re: [PATCH 06/21] perf tools: Update cpumode for each cumulative entry

On Sun, 5 Jan 2014 18:02:19 +0100, Jiri Olsa wrote:
> On Tue, Dec 24, 2013 at 05:22:12PM +0900, Namhyung Kim wrote:
[SNIP]

>> @@ -100,6 +100,7 @@ struct add_entry_iter {
>>  	struct report *rep;
>>  	struct perf_evsel *evsel;
>>  	struct perf_sample *sample;
>> +	struct machine *machine;
>>  	struct hist_entry *he;
>>  	struct symbol *parent;
>>  	void *priv;
>> @@ -362,7 +363,7 @@ iter_finish_normal_entry(struct add_entry_iter *iter, struct addr_location *al)
>>  
>>  static int
>>  iter_prepare_cumulative_entry(struct add_entry_iter *iter,
>> -			      struct machine *machine __maybe_unused,
>> +			      struct machine *machine,
>>  			      struct perf_evsel *evsel,
>>  			      struct addr_location *al __maybe_unused,
>>  			      struct perf_sample *sample)
>> @@ -371,6 +372,7 @@ iter_prepare_cumulative_entry(struct add_entry_iter *iter,
>>  
>>  	iter->evsel = evsel;
>>  	iter->sample = sample;
>> +	iter->machine = machine;
>
> machine is already in 'al->machine'

Okay, will remove ->machine in the iter.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/