| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1388970358.5808.37.camel@joe-AO722>
Date: Sun, 05 Jan 2014 17:05:58 -0800
From: Joe Perches <joe@...ches.com>
To: Jesper Falk <jesperfalk94@...il.com>
Cc: anton@...msg.org, dwmw2@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Power: ab8500: Fixed coding style issues
On Mon, 2014-01-06 at 01:50 +0100, Jesper Falk wrote:
> Fixed coding style.
It'd be nice to change some of these arrays to const too like:
diff --git a/include/linux/mfd/abx500.h b/include/linux/mfd/abx500.h
index 3301b20..9fa8c0c 100644
--- a/include/linux/mfd/abx500.h
+++ b/include/linux/mfd/abx500.h
@@ -287,8 +287,8 @@ struct abx500_bm_data {
int gnd_lift_resistance;
int n_chg_out_curr;
int n_chg_in_curr;
- int *chg_output_curr;
- int *chg_input_curr;
+ const int *chg_output_curr;
+ const int *chg_input_curr;
const struct abx500_maxim_parameters *maxi;
const struct abx500_bm_capacity_levels *cap_levels;
struct abx500_battery_type *bat_type;
> diff --git a/drivers/power/ab8500_bmdata.c b/drivers/power/ab8500_bmdata.c
[]
> @@ -448,19 +448,19 @@ static const struct abx500_bm_charger_parameters chg = {
> * AB8500 values
> */
> static int ab8500_charge_output_curr_map[] = {
static const int
> - 100, 200, 300, 400, 500, 600, 700, 800,
> - 900, 1000, 1100, 1200, 1300, 1400, 1500, 1500,
> + 100, 200, 300, 400, 500, 600, 700, 800,
> + 900, 1000, 1100, 1200, 1300, 1400, 1500, 1500,
> };
>
> static int ab8540_charge_output_curr_map[] = {
here too
> - 0, 0, 0, 75, 100, 125, 150, 175,
> - 200, 225, 250, 275, 300, 325, 350, 375,
> - 400, 425, 450, 475, 500, 525, 550, 575,
> - 600, 625, 650, 675, 700, 725, 750, 775,
> - 800, 825, 850, 875, 900, 925, 950, 975,
> - 1000, 1025, 1050, 1075, 1100, 1125, 1150, 1175,
> - 1200, 1225, 1250, 1275, 1300, 1325, 1350, 1375,
> - 1400, 1425, 1450, 1500, 1600, 1700, 1900, 2000,
> + 0, 0, 0, 75, 100, 125, 150, 175,
> + 200, 225, 250, 275, 300, 325, 350, 375,
> + 400, 425, 450, 475, 500, 525, 550, 575,
> + 600, 625, 650, 675, 700, 725, 750, 775,
> + 800, 825, 850, 875, 900, 925, 950, 975,
> + 1000, 1025, 1050, 1075, 1100, 1125, 1150, 1175,
> + 1200, 1225, 1250, 1275, 1300, 1325, 1350, 1375,
> + 1400, 1425, 1450, 1500, 1600, 1700, 1900, 2000,
> };
>
> /*
> @@ -468,19 +468,19 @@ static int ab8540_charge_output_curr_map[] = {
> * AB8500 values
> */
> static int ab8500_charge_input_curr_map[] = {
> - 50, 98, 193, 290, 380, 450, 500, 600,
> - 700, 800, 900, 1000, 1100, 1300, 1400, 1500,
> + 50, 98, 193, 290, 380, 450, 500, 600,
> + 700, 800, 900, 1000, 1100, 1300, 1400, 1500,
> };
here 3
> static int ab8540_charge_input_curr_map[] = {
> - 25, 50, 75, 100, 125, 150, 175, 200,
> - 225, 250, 275, 300, 325, 350, 375, 400,
> - 425, 450, 475, 500, 525, 550, 575, 600,
> - 625, 650, 675, 700, 725, 750, 775, 800,
> - 825, 850, 875, 900, 925, 950, 975, 1000,
> - 1025, 1050, 1075, 1100, 1125, 1150, 1175, 1200,
> - 1225, 1250, 1275, 1300, 1325, 1350, 1375, 1400,
> - 1425, 1450, 1475, 1500, 1500, 1500, 1500, 1500,
> + 25, 50, 75, 100, 125, 150, 175, 200,
> + 225, 250, 275, 300, 325, 350, 375, 400,
> + 425, 450, 475, 500, 525, 550, 575, 600,
> + 625, 650, 675, 700, 725, 750, 775, 800,
> + 825, 850, 875, 900, 925, 950, 975, 1000,
> + 1025, 1050, 1075, 1100, 1125, 1150, 1175, 1200,
> + 1225, 1250, 1275, 1300, 1325, 1350, 1375, 1400,
> + 1425, 1450, 1475, 1500, 1500, 1500, 1500, 1500,
> };
and here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists