lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140106090933.GM30234@mwanda>
Date:	Mon, 6 Jan 2014 12:09:34 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Aruna-Hewapathirane <aruna.hewapathirane@...il.com>
Cc:	abbotti@....co.uk, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style
 issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@...il.com>


Changelog mangled.  You need a blank after the subject.

On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote:
> ---
>  drivers/staging/comedi/drivers/ke_counter.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c
> index 15589f6..cebf818 100644
> --- a/drivers/staging/comedi/drivers/ke_counter.c
> +++ b/drivers/staging/comedi/drivers/ke_counter.c
> @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
>  	dev->read_subdev = s;
>  	s->type = COMEDI_SUBD_COUNTER;
> -	s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ;
> +	s->subdev_flags = SDF_READABLE /* | SDF_COMMON */;
>  	s->n_chan = 3;
>  	s->maxdata = 0x00ffffff;
>  	s->insn_read = cnt_rinsn;
> @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
>  	outb(0, dev->iobase + 0x40);
>  	dev_info(dev->class_dev, "%s: %s attached\n",
> -		dev->driver->driver_name, dev->board_name);
> +	dev->driver->driver_name, dev->board_name);

Nope.  The original was better.

regards,
dan carpenter

>  	return 0;
>  }
> --
> 1.7.0.4
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ