linux-kernel - Re: [PATCH 1/3] mfd: sta2x11-mfd: use named constants for pci_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140106114902.GB30156@lee--X1>
Date:	Mon, 6 Jan 2014 11:49:02 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mfd: sta2x11-mfd: use named constants for
 pci_power_t values

> > > From: Julia Lawall <Julia.Lawall@...6.fr>
> > >
> > > The semantic patch that makes this change is as follows:
> > > (http://coccinelle.lip6.fr/)
> > >
> > > // <smpl>
> > > @@
> > > expression pdev;
> > > @@
> > >
> > > pci_set_power_state(pdev,
> > > - 0
> > > + PCI_D0
> > >  )
> > > // </smpl>
> >
> > I'm happy with the code and that you used Coccinelle to discover the
> > issue, but I feel a little more explanation would be helpful to
> > readers.
> >
> > Why is (pci_power_t __force) 0 better than 0?
> 
> I wasn't particularly attached to the cast, and I don't know if it is an
> issue.  But in trying to understand the code, I found PCI_D0 more
> understandable than 0.

Well I don't want to waste any of your or my time, so I'll apply the
patch and add something along those lines to the commit message.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/