lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Jan 2014 11:20:43 +0800 From: hayeswang <hayeswang@...ltek.com> To: 'David Miller' <davem@...emloft.net> CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org> Subject: RE: [PATCH net-next] r8152: fix the wrong return value David Miller [mailto:davem@...emloft.net] > Sent: Saturday, January 04, 2014 9:38 AM > To: Hayeswang > Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; > linux-usb@...r.kernel.org > Subject: Re: [PATCH net-next] r8152: fix the wrong return value > > From: Hayes Wang <hayeswang@...ltek.com> > Date: Fri, 3 Jan 2014 11:21:56 +0800 > > > The return value should be the boolean value, not the error code. > > > > Signed-off-by: Hayes Wang <hayeswang@...ltek.com> > > Spotted-by: Dan Carpenter <dan.carpenter@...cle.com> > > Applied, but I agree with others that it's more canonical to have the > function return either an error code, or zero for success, rather than > a boolean. Thanks. I would find if there is suitable error code. Best Regards, Hayes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists