linux-kernel - [PATCH 44/85] drivers: gpu: Move prototype declaration to header file radeon_mode.h from radeon_atombios.c and radeon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <357ad7be5b1183a598bb64b8ebb21966d341bc86.1389018325.git.rashika.kheria@gmail.com>
Date:	Mon, 6 Jan 2014 21:23:37 +0530
From:	Rashika Kheria <rashika.kheria@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	David Airlie <airlied@...ux.ie>,
	Alex Deucher <alexander.deucher@....com>,
	Rashika Kheria <rashika.kheria@...il.com>,
	Christian König <christian.koenig@....com>,
	dri-devel@...ts.freedesktop.org, josh@...htriplett.org
Subject: [PATCH 44/85] drivers: gpu: Move prototype declaration to header
 file radeon_mode.h from radeon_atombios.c and radeon_encoders.c

Move prototype declarations of function radeon_add_atom_encoder() and
radeon_atom_backlight_init() to header file drm/radeon/radeon_mode.h
because they are used by more than one file.

This eliminates the following warning in drm/radeon/atombios_encoders.c:
drivers/gpu/drm/radeon/atombios_encoders.c:177:6: warning: no previous prototype for ‘radeon_atom_backlight_init’ [-Wmissing-prototypes]
drivers/gpu/drm/radeon/atombios_encoders.c:2600:1: warning: no previous prototype for ‘radeon_add_atom_encoder’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
Reviewed-by: Josh Triplett <josh@...htriplett.org>
---
 drivers/gpu/drm/radeon/radeon_atombios.c |    4 ----
 drivers/gpu/drm/radeon/radeon_encoders.c |    4 ----
 drivers/gpu/drm/radeon/radeon_mode.h     |    7 +++++++
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
index a876fae..19a7350 100644
--- a/drivers/gpu/drm/radeon/radeon_atombios.c
+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
@@ -32,10 +32,6 @@
 #include "radeon_asic.h"
 #include "atom-bits.h"
 
-extern void
-radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum,
-			uint32_t supported_device, u16 caps);
-
 /* from radeon_legacy_encoder.c */
 extern void
 radeon_add_legacy_encoder(struct drm_device *dev, uint32_t encoder_enum,
diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c
index bd4959c..a88ba7a 100644
--- a/drivers/gpu/drm/radeon/radeon_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_encoders.c
@@ -32,10 +32,6 @@
 extern void
 radeon_legacy_backlight_init(struct radeon_encoder *radeon_encoder,
 			     struct drm_connector *drm_connector);
-extern void
-radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder,
-			   struct drm_connector *drm_connector);
-
 
 static uint32_t radeon_encoder_clones(struct drm_encoder *encoder)
 {
diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h
index b5f4e52..8f2f4a3 100644
--- a/drivers/gpu/drm/radeon/radeon_mode.h
+++ b/drivers/gpu/drm/radeon/radeon_mode.h
@@ -628,6 +628,13 @@ struct atom_voltage_table
 	struct atom_voltage_table_entry entries[MAX_VOLTAGE_ENTRIES];
 };
 
+void
+radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder,
+			   struct drm_connector *drm_connector);
+
+void
+radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum,
+			uint32_t supported_device, u16 caps);
 
 void
 radeon_add_atom_connector(struct drm_device *dev,
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/