linux-kernel - [PATCH 62/85] drivers: gpu: Mark functions as static and remove unused function in trinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jan 2014 21:51:54 +0530
From:	Rashika Kheria <rashika.kheria@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	David Airlie <airlied@...ux.ie>,
	Alex Deucher <alexander.deucher@....com>,
	Rashika Kheria <rashika.kheria@...il.com>,
	dri-devel@...ts.freedesktop.org, josh@...htriplett.org
Subject: [PATCH 62/85] drivers: gpu: Mark functions as static and remove
 unused function in trinity_dpm.c

Mark function trinity_get_ps() and trinity_get_pi() as static because
they are not used outside this file and remove unused function
trinity_dpm_reset_asic() from file drm/radeon/trinity_dpm.c.

Also remove prototype declarations of functions trinity_get_ps() and
trinity_get_pi() from drm/radeon/trinity_smc.c because they are not used
in this file.

This eliminates the following warnings in drm/radeon/trinity_dpm.c:
drivers/gpu/drm/radeon/trinity_dpm.c:345:20: warning: no previous prototype for ‘trinity_get_ps’ [-Wmissing-prototypes]
drivers/gpu/drm/radeon/trinity_dpm.c:352:28: warning: no previous prototype for ‘trinity_get_pi’ [-Wmissing-prototypes]
drivers/gpu/drm/radeon/trinity_dpm.c:1262:6: warning: no previous prototype for ‘trinity_dpm_reset_asic’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
Reviewed-by: Josh Triplett <josh@...htriplett.org>
---
 drivers/gpu/drm/radeon/trinity_dpm.c |   20 ++------------------
 drivers/gpu/drm/radeon/trinity_smc.c |    3 ---
 2 files changed, 2 insertions(+), 21 deletions(-)

diff --git a/drivers/gpu/drm/radeon/trinity_dpm.c b/drivers/gpu/drm/radeon/trinity_dpm.c
index d700698..83778b6 100644
--- a/drivers/gpu/drm/radeon/trinity_dpm.c
+++ b/drivers/gpu/drm/radeon/trinity_dpm.c
@@ -342,14 +342,14 @@ static void trinity_apply_state_adjust_rules(struct radeon_device *rdev,
 					     struct radeon_ps *new_rps,
 					     struct radeon_ps *old_rps);
 
-struct trinity_ps *trinity_get_ps(struct radeon_ps *rps)
+static struct trinity_ps *trinity_get_ps(struct radeon_ps *rps)
 {
 	struct trinity_ps *ps = rps->ps_priv;
 
 	return ps;
 }
 
-struct trinity_power_info *trinity_get_pi(struct radeon_device *rdev)
+static struct trinity_power_info *trinity_get_pi(struct radeon_device *rdev)
 {
 	struct trinity_power_info *pi = rdev->pm.dpm.priv;
 
@@ -1259,22 +1259,6 @@ void trinity_dpm_setup_asic(struct radeon_device *rdev)
 	trinity_release_mutex(rdev);
 }
 
-void trinity_dpm_reset_asic(struct radeon_device *rdev)
-{
-	struct trinity_power_info *pi = trinity_get_pi(rdev);
-
-	trinity_acquire_mutex(rdev);
-	if (pi->enable_dpm) {
-		trinity_enable_power_level_0(rdev);
-		trinity_force_level_0(rdev);
-		trinity_wait_for_level_0(rdev);
-		trinity_program_bootup_state(rdev);
-		trinity_force_level_0(rdev);
-		trinity_unforce_levels(rdev);
-	}
-	trinity_release_mutex(rdev);
-}
-
 static u16 trinity_convert_voltage_index_to_value(struct radeon_device *rdev,
 						  u32 vid_2bit)
 {
diff --git a/drivers/gpu/drm/radeon/trinity_smc.c b/drivers/gpu/drm/radeon/trinity_smc.c
index 9672bcb..99dd045 100644
--- a/drivers/gpu/drm/radeon/trinity_smc.c
+++ b/drivers/gpu/drm/radeon/trinity_smc.c
@@ -27,9 +27,6 @@
 #include "trinity_dpm.h"
 #include "ppsmc.h"
 
-struct trinity_ps *trinity_get_ps(struct radeon_ps *rps);
-struct trinity_power_info *trinity_get_pi(struct radeon_device *rdev);
-
 static int trinity_notify_message_to_smu(struct radeon_device *rdev, u32 id)
 {
 	int i;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/