linux-kernel - Re: [PATCH v2] isdn: Mark build for telespci and hfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52CA3045.80807@roeck-us.net>
Date:	Sun, 05 Jan 2014 20:25:41 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	David Miller <davem@...emloft.net>
CC:	isdn@...ux-pingi.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] isdn: Mark build for telespci and hfc_pci as broken
 for big endian ARM

On 01/05/2014 05:39 PM, David Miller wrote:
> From: Guenter Roeck <linux@...ck-us.net>
> Date: Sun,  5 Jan 2014 11:49:27 -0800
>
>> With arm:allmodconfig, building the Teles PCI driver fails with
>>
>> telespci.c:294:2: error: #error "not running on big endian machines now"
>>
>> Similar, building the driver for HFC PCI-Bus cards fails with
>>
>> hfc_pci.c:1647:2: error: #error "not running on big endian machines now"
>>
>> Mark build as broken for big endian ARM machines.
>>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>
> Let's not start getting into the habit of doing this, please.
>
> The reason this isn't easy to do generically from Kconfig is
> probably because it almost never makes any sense to do so.
>
> In fact, if you look at telespci.c there are no DMA descriptors,
> everything is read using MMIO acccesses via the chips FIFO.  There
> really can't be any endianness problems that I see.
>
> Please just remove the CPP checks, that's the best fix.
>

Both drivers build with arm:allmodconfig if I remove the check,
so I am fine with that. I'll send an updated patch.

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/