linux-kernel - Re: [PATCH v4 01/15] reset: Silence warning in reset-controller.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Jan 2014 18:28:04 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Mike Turquette <mturquette@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Saravana Kannan <skannan@...eaurora.org>
Subject: Re: [PATCH v4 01/15] reset: Silence warning in reset-controller.h

Am Montag, den 23.12.2013, 17:12 -0800 schrieb Stephen Boyd:
> If a user of <linux/reset-controller.h> doesn't include
> <linux/of.h> before including reset-controller.h they'll get a
> warning as follows:
> 
>   include/linux/reset-controller.h:44:17:
>   warning: 'struct of_phandle_args' declared inside parameter list
> 
> This is because of_phandle_args is not forward declared. Add the
> declaration to silence this warning.
> 
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
>  include/linux/reset-controller.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/reset-controller.h b/include/linux/reset-controller.h
> index 2f61311..41a4695 100644
> --- a/include/linux/reset-controller.h
> +++ b/include/linux/reset-controller.h
> @@ -21,6 +21,7 @@ struct reset_control_ops {
>  
>  struct module;
>  struct device_node;
> +struct of_phandle_args;
>  
>  /**
>   * struct reset_controller_dev - reset controller entity that might

Since this is only a warning, I see no need for this to go through the
clock tree. On the other hand there are no merge conflicts to be
expected, so that's fine with me either way.

Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/