lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 06 Jan 2014 09:34:58 -0800 From: Joe Perches <joe@...ches.com> To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> Cc: keescook@...omium.org, pavel@....cz, akpm@...ux-foundation.org, geert@...ux-m68k.org, jkosina@...e.cz, viro@...iv.linux.org.uk, davem@...emloft.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] lib/vsprintf: add %pT[C012] format specifier On Mon, 2014-01-06 at 23:00 +0900, Tetsuo Handa wrote: > Joe Perches wrote: > > Is this really necessary? > No problem. %pT[012] are simply optimization (reducing number of function > arguments for saving text size) and therefore I can drop them. > What about below patch? Hi Tetsuo. Just a nit. > diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] > @@ -1232,7 +1248,7 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr, > { > int default_width = 2 * sizeof(void *) + (spec.flags & SPECIAL ? 2 : 0); > > - if (!ptr && *fmt != 'K') { > + if (!ptr && *fmt != 'K' && *fmt != 'T') { I think this new 'T' comparison isn't necessary. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists