linux-kernel - Re: [PATCH v2] extcon: gpio: Add power resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4zYRL2aM4vMxY6RT41ow3M1AjFDpcAcf2itarRjeF2CWA@mail.gmail.com>
Date:	Tue, 7 Jan 2014 10:26:12 +0800
From:	Barry Song <21cnbao@...il.com>
To:	rjying <rjying@...il.com>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Barry Song <Barry.Song@....com>,
	DL-SHA-WorkGroupLinux <Workgroup.linux@....com>,
	Rongjun Ying <rongjun.ying@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] extcon: gpio: Add power resume support

2013/12/27 rjying <rjying@...il.com>:
> From: Rongjun Ying <rongjun.ying@....com>
>
> When system on the suspend state, Some SoC can't get gpio interrupt.
> After system resume, need send extcon uevent to userspace.
>
> Signed-off-by: Rongjun Ying <rongjun.ying@....com>

Reviewed-by: Barry Song <Baohua.Song@....com>

for CSR SiRFSoC, we need similar patch in extcon to make the lost
plug/unplug event during sleeping to be resent.

> ---
>  -v2: Add lost_sleep_irq flags.
>
>  drivers/extcon/extcon-gpio.c       |   20 ++++++++++++++++++++
>  include/linux/extcon/extcon-gpio.h |    1 +
>  2 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index 7e0dff5..fde52c1 100644
> --- a/drivers/extcon/extcon-gpio.c
> +++ b/drivers/extcon/extcon-gpio.c
> @@ -40,6 +40,7 @@ struct gpio_extcon_data {
>         int irq;
>         struct delayed_work work;
>         unsigned long debounce_jiffies;
> +       bool lost_sleep_irq;
>  };
>
>  static void gpio_extcon_work(struct work_struct *work)
> @@ -103,6 +104,7 @@ static int gpio_extcon_probe(struct platform_device *pdev)
>         extcon_data->gpio_active_low = pdata->gpio_active_low;
>         extcon_data->state_on = pdata->state_on;
>         extcon_data->state_off = pdata->state_off;
> +       extcon_data->lost_sleep_irq = pdata->lost_sleep_irq;
>         if (pdata->state_on && pdata->state_off)
>                 extcon_data->edev.print_state = extcon_gpio_print_state;
>         if (pdata->debounce) {
> @@ -159,12 +161,30 @@ static int gpio_extcon_remove(struct platform_device *pdev)
>         return 0;
>  }
>
> +#ifdef CONFIG_PM_SLEEP
> +static int gpio_extcon_resume(struct device *dev)
> +{
> +       struct gpio_extcon_data *extcon_data;
> +
> +       extcon_data = dev_get_drvdata(dev);
> +       if (extcon_data->lost_sleep_irq)
> +               queue_delayed_work(system_power_efficient_wq,
> +                       &extcon_data->work, extcon_data->debounce_jiffies);
> +       return 0;
> +}
> +#endif
> +
> +static const struct dev_pm_ops gpio_extcon_pm_ops = {
> +       SET_SYSTEM_SLEEP_PM_OPS(NULL, gpio_extcon_resume)
> +};
> +
>  static struct platform_driver gpio_extcon_driver = {
>         .probe          = gpio_extcon_probe,
>         .remove         = gpio_extcon_remove,
>         .driver         = {
>                 .name   = "extcon-gpio",
>                 .owner  = THIS_MODULE,
> +               .pm = &gpio_extcon_pm_ops,
>         },
>  };
>
> diff --git a/include/linux/extcon/extcon-gpio.h b/include/linux/extcon/extcon-gpio.h
> index 4195810..c7f0c3e 100644
> --- a/include/linux/extcon/extcon-gpio.h
> +++ b/include/linux/extcon/extcon-gpio.h
> @@ -51,6 +51,7 @@ struct gpio_extcon_platform_data {
>         /* if NULL, "0" or "1" will be printed */
>         const char *state_on;
>         const char *state_off;
> +       bool lost_sleep_irq;
>  };
>
>  #endif /* __EXTCON_GPIO_H__ */
> --
> 1.7.5.4

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/