linux-kernel - Re: [PATCH 1/2] GenWQE: Fix endian issues detected by sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140107064130.GA5494@mwanda>
Date:	Tue, 7 Jan 2014 09:41:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
Cc:	fengguang.wu@...el.com, jim.epost@...il.com, sfr@...b.auug.org.au,
	gregkh@...uxfoundation.org, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH 1/2] GenWQE: Fix endian issues detected by sparse

Could you also fix this Smatch warning?
drivers/misc/genwqe/card_dev.c:658 do_flash_update() warn: maybe return -EFAULT instead of the bytes remaining?

Also we shouldn't be doing dev_err() on copy_to/from_user() problems.
The user can trigger those and flood dmesg.  It is a DoS (annoying).

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/