linux-kernel - Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jan 2014 09:09:38 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Laszlo Papp <lpapp@....org>
Cc:	Guenter Roeck <linux@...ck-us.net>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Add GPIO support for the MAX6650/6651 ICs

Don't send private, off-list emails for poking or anything else
related to upstreamming patches.

> Important text here later. It is now just an attempt to get some feedback about
> the design of the new features. This set has only been compilation tested, and
> has many errors with checkpatch.pl, et al. Really, the point is only to get
> feedback about the direction, as there has been a lot of paid work put into
> this to work better with upstream after the previously rejected change simple
> hwmon change.

If you want to obtain time/advice from maintainers, most of which are
already snowed-under, you have to earn it. Making submissions such as
these are not conducive to your cause. Fix the Checkpatch errors and
do your damnedest to ensure the code is the finest standard it can be.

If you fail to adhere to these [1] three documents accidentally, then
you will be guided. If you do so on purpose by sending intentionally
sloppy code, then you are unlikely to gain any attention at all.

[1]
  Documentation/CodingStyle
  Documentation/email-clients.txt
  Documentation/SubmittingPatches

> Laszlo Papp (3):
>   mfd: MAX6650/6651 support
>   hwmon: (max6650) Convert to be a platform driver
>   gpio: MAX6650/6651 support
> 
>  drivers/gpio/Kconfig                |  14 ++
>  drivers/gpio/Makefile               |   2 +
>  drivers/gpio/gpio-max6651.c         |  72 +++++++++
>  drivers/gpio/gpio-max665x.c         | 301 ++++++++++++++++++++++++++++++++++++
>  drivers/hwmon/Kconfig               |   2 +-
>  drivers/hwmon/max6650.c             | 150 +++++++++---------
>  drivers/mfd/Kconfig                 |  11 ++
>  drivers/mfd/Makefile                |   1 +
>  drivers/mfd/max6651.c               | 132 ++++++++++++++++
>  include/linux/mfd/max6651-private.h |  63 ++++++++
>  10 files changed, 675 insertions(+), 73 deletions(-)
>  create mode 100644 drivers/gpio/gpio-max6651.c
>  create mode 100644 drivers/gpio/gpio-max665x.c
>  create mode 100644 drivers/mfd/max6651.c
>  create mode 100644 include/linux/mfd/max6651-private.h
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/