linux-kernel - Re: [PATCH] swiotlb: Don't DoS us with 'swiotlb buffer is full'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1401071303110.8667@kaball.uk.xensource.com>
Date:	Tue, 7 Jan 2014 13:03:34 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] swiotlb: Don't DoS us with 'swiotlb buffer is full'

On Mon, 6 Jan 2014, Konrad Rzeszutek Wilk wrote:
> On Fri, Jan 03, 2014 at 01:35:52PM +0000, Stefano Stabellini wrote:
> > On Tue, 31 Dec 2013, Konrad Rzeszutek Wilk wrote:
> > > There is no need for that so lets use ratelimiting.
> > > Also add some extra information to be helpful.
> > > 
> > > CC: Stefano Stabellini <stefano.stabellini@...citrix.com>
> > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> > 
> > lib/swiotlb.c: In function 'swiotlb_tbl_map_single':
> > lib/swiotlb.c:509:3: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' [-Wformat=]
> > 
> 
> How about this:
> 
> >From c83a2ab5d5fbc502b4165262a2983c2ad646f061 Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Date: Mon, 16 Dec 2013 14:05:01 -0500
> Subject: [PATCH] swiotlb: Don't DoS us with 'swiotlb buffer is full' (v2)
> 
> There is no need for that so lets use ratelimiting.
> Also add some extra information to be helpful.
> 
> CC: Stefano Stabellini <stefano.stabellini@...citrix.com>
> [v2: s/ld/zs on the printk]
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>

Acked-by: Stefano Stabellini <stefano.stabellini@...citrix.com>


>  lib/swiotlb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> index e4399fa..4634ac9 100644
> --- a/lib/swiotlb.c
> +++ b/lib/swiotlb.c
> @@ -505,7 +505,8 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
>  
>  not_found:
>  	spin_unlock_irqrestore(&io_tlb_lock, flags);
> -	dev_warn(hwdev, "swiotlb buffer is full\n");
> +	if (printk_ratelimit())
> +		dev_warn(hwdev, "swiotlb buffer is full (sz: %zd bytes)\n", size);
>  	return SWIOTLB_MAP_ERROR;
>  found:
>  	spin_unlock_irqrestore(&io_tlb_lock, flags);
> -- 
> 1.8.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/