linux-kernel - Re: [PATCH 02/16] perf tools: Fix machine initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140107142225.GC2919@krava.brq.redhat.com>
Date:	Tue, 7 Jan 2014 15:22:25 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	David Ahern <dsahern@...il.com>,
	Jean Pihet <jean.pihet@...aro.org>
Subject: Re: [PATCH 02/16] perf tools: Fix machine initialization

On Tue, Jan 07, 2014 at 11:14:00AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 07, 2014 at 01:47:19PM +0100, Jiri Olsa escreveu:
> > The id_hdr_size field was not properly initialized,
> > setting it to zero.
> 
> Humm, is there any place where 'machine' doesn't come from calloc/zalloc?

machine__new_host, but I used machine allocated on stack
in the tests/dwarf-unwind.c and I thought this was the last
member not being initialized..

now I can see vmlinux_maps array does not get initialized as well..

jirka

> 
> - Arnaldo
>  
> > Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> > Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
> > Cc: Frederic Weisbecker <fweisbec@...il.com>
> > Cc: Ingo Molnar <mingo@...nel.org>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Paul Mackerras <paulus@...ba.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
> > Cc: David Ahern <dsahern@...il.com>
> > Cc: Jean Pihet <jean.pihet@...aro.org>
> > ---
> >  tools/perf/util/machine.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> > index a98538d..0130279 100644
> > --- a/tools/perf/util/machine.c
> > +++ b/tools/perf/util/machine.c
> > @@ -27,6 +27,7 @@ int machine__init(struct machine *machine, const char *root_dir, pid_t pid)
> >  	machine->pid = pid;
> >  
> >  	machine->symbol_filter = NULL;
> > +	machine->id_hdr_size = 0;
> >  
> >  	machine->root_dir = strdup(root_dir);
> >  	if (machine->root_dir == NULL)
> > -- 
> > 1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/