linux-kernel - Re: [PATCH] hwmon/sensors: fix SENSORS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140107161018.GB24018@roeck-us.net>
Date:	Tue, 7 Jan 2014 08:10:18 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Eduardo Valentin <eduardo.valentin@...com>,
	"Zhang, Rui" <rui.zhang@...el.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	lm-sensors@...sensors.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] hwmon/sensors: fix SENSORS_LM75 dependencies

On Tue, Jan 07, 2014 at 04:07:38PM +0100, Jean Delvare wrote:
> On Tue, 7 Jan 2014 10:57:52 -0400, Eduardo Valentin wrote:
> > On 07-01-2014 10:05, Zhang, Rui wrote:
> > > BTW, I've been thinking of make CONFIG_THERMAL a bool since long time ago, the only thing that blocks me is that Thermal subsystem needs to register a hwmon device for each thermal zone and CONFIG_HWMON is a tristate.
> > 
> > I agree with the move of having CONFIG_THERMAL as bool. Unless you have
> > use cases where users are dynamically loading and unloading thermal per
> > user demand, which I doubt.
> 
> Modularity is not only about reloading modules (although this can be
> useful for developers in particular.) It's also about enabling many
> features in a generic distribution kernel and each feature only gets
> loaded/used on the hardware which needs it. This is why, as a
> distribution kernel maintainer, I keep complaining when I see boolean
> options which might easily be tristates.
> 
Agreed. Problem is really that it is not easy to declare cross-module
dependencies (eg THERMAL=m -> HWMON=m and THERMAL=y -> HWMON=y and
vice versa) in Kconfig. Declaring everything as bool can not be
the solution to that.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/