linux-kernel - Re: [PATCH v2] ASoC: soc-core: add snd_soc_of_parse_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140107170538.GA31886@sirena.org.uk>
Date:	Tue, 7 Jan 2014 17:05:38 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: soc-core: add snd_soc_of_parse_master_clkdir()
 for dt

On Thu, Jan 02, 2014 at 10:48:25AM +0800, Xiubo Li wrote:
> This patch adds snd_soc_of_parse_master_clkdir() and supports below
> style on dt:
> 
> master-clkdir-out;
> 
> If this property is absent 0 will be returned, 1 otherwise.
> 0 : SND_SOC_CLOCK_IN
> 1 : SND_SOC_CLOCK_OUT

This is mostly OK code wise, though it would be good to use those
constants in the code.  However I'm still not sure about it being a good
idea - it's similar issues to those with clock IDs but less strong.  Do
you have a user in mind?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)