linux-kernel - Re: [PATCH 3.10 075/129] mm/mempolicy: correct putback method for isolate pages if failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140107172659.GC4383@hercules>
Date:	Tue, 7 Jan 2014 17:26:59 +0000
From:	Luis Henriques <luis.henriques@...onical.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Rafael Aquini <aquini@...hat.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Wanpeng Li <liwanp@...ux.vnet.ibm.com>,
	Christoph Lameter <cl@...ux.com>,
	Vlastimil Babka <vbabka@...e.cz>, Mel Gorman <mgorman@...e.de>,
	Rik van Riel <riel@...hat.com>,
	Zhang Yanfei <zhangyanfei@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 3.10 075/129] mm/mempolicy: correct putback method for
 isolate pages if failed

On Mon, Jan 06, 2014 at 02:38:24PM -0800, Greg Kroah-Hartman wrote:
> 3.10-stable review patch.  If anyone has any objections, please let me know.

This commit was tagged for 3.12 stable only, so you may want to drop it.

Cheers,
--
Luis


> ------------------
> 
> From: Joonsoo Kim <iamjoonsoo.kim@....com>
> 
> commit b0e5fd7359f1ce8db4ccb862b3aa80d2f2cbf4d0 upstream.
> 
> queue_pages_range() isolates hugetlbfs pages and putback_lru_pages()
> can't handle these.  We should change it to putback_movable_pages().
> 
> Naoya said that it is worth going into stable, because it can break
> in-use hugepage list.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com>
> Acked-by: Rafael Aquini <aquini@...hat.com>
> Reviewed-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
> Reviewed-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> Cc: Christoph Lameter <cl@...ux.com>
> Cc: Vlastimil Babka <vbabka@...e.cz>
> Cc: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Rik van Riel <riel@...hat.com>
> Cc: Vlastimil Babka <vbabka@...e.cz>
> Cc: Zhang Yanfei <zhangyanfei@...fujitsu.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> ---
>  mm/mempolicy.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1271,7 +1271,7 @@ static long do_mbind(unsigned long start
>  		if (nr_failed && (flags & MPOL_MF_STRICT))
>  			err = -EIO;
>  	} else
> -		putback_lru_pages(&pagelist);
> +		putback_movable_pages(&pagelist);
>  
>  	up_write(&mm->mmap_sem);
>   mpol_out:
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/