linux-kernel - Re: [PATCH V2] leds: s3c24xx: Fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK5ve-+05zO0CjFnb0hJoy_txys6q3orRoqdaXLWv91O0=cdpQ@mail.gmail.com>
Date:	Tue, 7 Jan 2014 09:43:09 -0800
From:	Bryan Wu <cooloney@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Tushar Behera <tushar.behera@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	"rpurdie@...ys.net" <rpurdie@...ys.net>
Subject: Re: [PATCH V2] leds: s3c24xx: Fix build failure

On Tue, Jan 7, 2014 at 9:41 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Fri, Jan 3, 2014 at 7:19 AM, Bryan Wu <cooloney@...il.com> wrote:
>> On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <tushar.behera@...aro.org> wrote:
>>> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
>>> removed the usage of mach/gpio.h file, but we need to include
>>> plat/gpio-cfg.h to avoid following build error.
>>>
>>> Fixes following build error.
>>> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
>>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>>> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
>>>
>>
>> I think this patch should go with Linus's patchset.
>
> Patch applied to the GPIO tree. I added your ACK Bryan since
> that seems to be implied above ...
>
Sure, thanks.
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/