linux-kernel - Re: [PATCH v2] ftrace/x86: Load ftrace_ops in parameter not the variable holding it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140107135906.1c4cc3a0@gandalf.local.home>
Date:	Tue, 7 Jan 2014 13:59:06 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] ftrace/x86: Load ftrace_ops in parameter not the
 variable holding it

On Wed, 13 Nov 2013 13:06:33 -0800
"H. Peter Anvin" <hpa@...ux.intel.com> wrote:

> On 11/13/2013 12:20 PM, Steven Rostedt wrote:
> > 
> > Function tracing callbacks expect to have the ftrace_ops that registered it
> > passed to them, not the address of the variable that holds the ftrace_ops
> > that registered it.
> > 
> > Use a mov instead of a lea to store the ftrace_ops into the parameter
> > of the function tracing callback.
> > 
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> 
> This looks like an urgent fix, am I correct?

Hi Peter, I think this patch got missed somehow. Can you pull it in.
You can also add Masami's reviewed-by tag too.

Also add the following tags:

Cc: stable@...r.kernel.org # 3.8+
Fixes: 2f5f6ad9390c1 ("ftrace: Pass ftrace_ops as third parameter to
function trace callback")

Thanks!

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/