linux-kernel - Re: [PATCH] drm/msm: Fix link error with !MSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140107225345.GE29041@8bytes.org>
Date:	Tue, 7 Jan 2014 23:53:45 +0100
From:	Joerg Roedel <joro@...tes.org>
To:	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Cc:	Rob Clark <robdclark@...il.com>
Subject: Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU

On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote:
> The DRM driver for MSM depends on symbols from the MSM
> IOMMU driver. Add this dependency to the Kconfig file.
> 
> Fixes this comile error:
> 
>   Kernel: arch/arm/boot/zImage is ready
>   ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko]
>   undefined!
>   make[2]: *** [__modpost] Error 1
> 
> Cc: Rob Clark <robdclark@...il.com>
> Signed-off-by: Joerg Roedel <joro@...tes.org>
> ---
>  drivers/gpu/drm/msm/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index f39ab75..d3de8e1 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -4,6 +4,7 @@ config DRM_MSM
>  	depends on DRM
>  	depends on ARCH_MSM
>  	depends on ARCH_MSM8960
> +	depends on MSM_IOMMU
>  	select DRM_KMS_HELPER
>  	select SHMEM
>  	select TMPFS

FYI, I put the patch to my arm/msm branch meanwhile to get the build
error fixed. Please let me know when there is another solution merged
and I will drop it.


	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/