linux-kernel - Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1389170133.10763.6.camel@umadbro>
Date:	Wed, 08 Jan 2014 09:35:33 +0100
From:	Rostislav Lisovy <lisovy@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Ian Abbott <abbotti@....co.uk>,
	Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	pisa@....felk.cvut.cz
Subject: Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

Hello Dan;

On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote:
> On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote:
> > This patch adds Comedi driver for Humusoft MF634 (PCIe) and
> > MF624 (PCI) data acquisition cards. The legacy card Humusoft
> > MF614 is not supported. More info about the cards may be found
> > at http://humusoft.cz/produkty/datacq/
> > The driver was tested with both cards. Everything seems to work
> > properly. Just the basic functionality of the card (DIO, ADC, DAC)
> > is supported by this driver.
> > 
> > Signed-off-by: Rostislav Lisovy <lisovy@...il.com>
> > 
> >  create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
> > 
> 
> There should be a "---" after the Signed-off-by line and before the
> diffstat "create mode 100644 drivers/staging/comedi/drivers/mf6x4.c"
> line.  Otherwise, the diffstat gets included in the changelog.
> 
> Signed-off-by: Rostislav Lisovy <lisovy@...il.com>
> ---
> create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
> 

You are right, my mistake. But even though there should be v3 patch
because I just realized there is an unnecessary comment in
mf6x4_detach() and MF6X4_DAC_CHANN_CNT constant is no more used.

Regards;
Rostislav Lisovy


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/