linux-kernel - Re: [PATCH 5/5] ARM: exynos5420: add dt node for sss module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1420297.0gEDu9oNDc@flatron>
Date:	Wed, 08 Jan 2014 01:32:35 +0100
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Naveen Krishna Ch <ch.naveen@...sung.com>
Cc:	linux-crypto@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org, vzapolskiy@...il.com,
	herbert@...dor.apana.org.au, naveenkrishna.ch@...il.com,
	cpgs@...sung.com, Kukjin Kim <kgene.kim@...sung.com>
Subject: Re: [PATCH 5/5] ARM: exynos5420: add dt node for sss module

On Tuesday 07 of January 2014 17:21:49 Naveen Krishna Ch wrote:
> From: Naveen Krishna Chatradhi <ch.naveen@...sung.com>
> 
> this patch adds the device tree nodes for SSS module found on Exynos5420

nit: Sentences in English start with a capital letter. Also this patch
adds one node, not few of them as the description suggests.

Also patch subject should start with ARM: dts: prefix.

> 
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com>
> TO: <linux-samsung-soc@...r.kernel.org>
> CC: Kukjin Kim <kgene.kim@...sung.com>
> CC: <linux-crypto@...r.kernel.org>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 11dd202..97045f9 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -652,4 +652,14 @@
>  		clocks = <&clock 319>, <&clock 318>;
>  		clock-names = "tmu_apbif", "tmu_triminfo_apbif";
>  	};
> +
> +	sss: sss {

Node name should be sss@...30000 as per ePAPR node naming recommendation.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/