linux-kernel - Re: [PATCH v2] mfd: omap-usb-tll: Don't hold lock during pm_runtime_get/put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140108091237.GE19974@lee--X1>
Date:	Wed, 8 Jan 2014 09:12:37 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Roger Quadros <rogerq@...com>
Cc:	sameo@...ux.intel.com, balbi@...com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] mfd: omap-usb-tll: Don't hold lock during
 pm_runtime_get/put_sync()

> pm_runtime_get/put_sync() can sleep so don't hold spinlock while
> calling them.
> 
> This patch prevents a BUG() during system suspend when
> CONFIG_DEBUG_ATOMIC_SLEEP is enabled.
> 
> Bug is present in Kernel versions v3.9 onwards.
> 
> Reported-by: Tomi Valkeinen <tomi.valkeinen@...com>
> Signed-off-by: Roger Quadros <rogerq@...com>
> Tested-by: Tomi Valkeinen <tomi.valkeinen@...com>
> Cc: <stable@...r.kernel.org> # 3.9+
> ---
>  drivers/mfd/omap-usb-tll.c | 36 ++++++++++++------------------------
>  1 file changed, 12 insertions(+), 24 deletions(-)

Patch looks good to me now.

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/