linux-kernel - Re: [PATCH 1/3] mfd: Add support for S2MPA01 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Jan 2014 14:51:15 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>, robh+dt@...nel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	Sangbeom Kim <sbkim73@...sung.com>,
	Patch Tracking <patches@...aro.org>
Subject: Re: [PATCH 1/3] mfd: Add support for S2MPA01 device

Hi Lee,

Thanks for the review.

On 8 January 2014 14:32, Lee Jones <lee.jones@...aro.org> wrote:
>> Add the necessary entries required for S2MPA01 multi-function
>> device. While at it also convert whitespaces to tabs in core.h.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
>> ---
>>  drivers/mfd/sec-core.c              |   39 +++++++
>>  include/linux/mfd/samsung/core.h    |   16 ++-
>>  include/linux/mfd/samsung/irq.h     |   50 +++++++++
>>  include/linux/mfd/samsung/s2mpa01.h |  192 +++++++++++++++++++++++++++++++++++
>>  4 files changed, 292 insertions(+), 5 deletions(-)
>>  create mode 100644 include/linux/mfd/samsung/s2mpa01.h
>>
>> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
>> index a139798b8065..d2e890d50a36 100644
>> --- a/drivers/mfd/sec-core.c
>> +++ b/drivers/mfd/sec-core.c
>> @@ -26,6 +26,7 @@
>>  #include <linux/mfd/samsung/core.h>
>>  #include <linux/mfd/samsung/irq.h>
>>  #include <linux/mfd/samsung/rtc.h>
>> +#include <linux/mfd/samsung/s2mpa01.h>
>>  #include <linux/mfd/samsung/s2mps11.h>
>>  #include <linux/mfd/samsung/s5m8763.h>
>>  #include <linux/mfd/samsung/s5m8767.h>
>> @@ -69,6 +70,13 @@ static const struct mfd_cell s2mps11_devs[] = {
>>       }
>>  };
>>
>> +static const struct mfd_cell s2mpa01_devs[] = {
>> +     {
>> +             .name = "s2mpa01-pmic",
>> +     },
>> +};
>> +
>> +
>
> Extra '/n' here.

Right. Will remove it.

>
>>  #ifdef CONFIG_OF
>>  static struct of_device_id sec_dt_match[] = {
>>       {       .compatible = "samsung,s5m8767-pmic",
>> @@ -77,10 +85,25 @@ static struct of_device_id sec_dt_match[] = {
>>       {       .compatible = "samsung,s2mps11-pmic",
>>               .data = (void *)S2MPS11X,
>>       },
>> +     {       .compatible = "samsung,s2mpa01-pmic",
>> +             .data = (void *)S2MPA01,
>> +     },
>
> Can you use the same format at the rest of the file.
>
> I'm happy for you to fix the entire struct in this patch.
>
> Rest of the file uses overlapping format:

Sure. I formatted it as per the current structure without noticing the others.
Will change it.

>
>         }, {
>                 .compatible = "samsung,s2mpa01-pmic",
>         },
>
>
> <snip>
>
>> @@ -92,7 +93,7 @@ struct sec_platform_data {
>>       int                             buck3_default_idx;
>>       int                             buck4_default_idx;
>>
>> -     int                             buck_ramp_delay;
>> +     int                             buck_ramp_delay;
>
> What's this? Are you fixing (or breaking) white space here?

I didn't get you. I have converted spaces to tabs here. See some problem?


-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/