lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Jan 2014 16:34:18 +0530 From: Roger Quadros <rogerq@...com> To: Arnd Bergmann <arnd@...db.de>, <linux-arm-kernel@...ts.infradead.org> CC: <devicetree@...r.kernel.org>, Samuel Ortiz <sameo@...ux.intel.com>, <tony@...mide.com>, <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <balbi@...com>, "Kristo, Tero" <t-kristo@...com>, <bcousson@...libre.com>, <linux-omap@...r.kernel.org>, Lee Jones <lee.jones@...aro.org> Subject: Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information On 01/08/2014 04:10 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 15:57:19 Roger Quadros wrote: >> It is a clock gate defined like so in the DT clock data >> >> on OMAP4 >> init_60m_fclk: init_60m_fclk { >> #clock-cells = <0>; >> compatible = "ti,divider-clock"; >> clocks = <&dpll_usb_m2_ck>; >> reg = <0x0104>; >> ti,dividers = <1>, <8>; >> }; >> >> on OMAP5 >> l3init_60m_fclk: l3init_60m_fclk { >> #clock-cells = <0>; >> compatible = "ti,divider-clock"; >> clocks = <&dpll_usb_m2_ck>; >> reg = <0x0104>; >> ti,dividers = <1>, <8>; >> }; >> >> So you can see that it is the same thing with a different name. > > Right, but init_60m_fclk is the name of the clock output of the > divider here, which is /not/ what you should put in the "clock-names" > property of the consumer. The clock input name should reflect what > the clock is used for instead. Ah, now I get it. :). I agree that the name should reflect the function. Looking more closely, the driver doesn't enable/disable the init_60m_fclk but just uses it to configure the parent of utmi_p1_gfclk which is a clock input to the USB module. Based on this I would call it "refclk_int" for internal reference clock. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists