linux-kernel - Re: [PATCH 2/3] regulator: Add support for S2MPA01 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140108123002.GY31886@sirena.org.uk>
Date:	Wed, 8 Jan 2014 12:30:02 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	lee.jones@...aro.org, robh+dt@...nel.org, lgirdwood@...il.com,
	sameo@...ux.intel.com, sbkim73@...sung.com, patches@...aro.org
Subject: Re: [PATCH 2/3] regulator: Add support for S2MPA01 regulator

On Wed, Jan 08, 2014 at 11:56:29AM +0530, Sachin Kamat wrote:

> +	if (!iodev->dev->of_node) {
> +		if (pdata) {
> +			goto common_reg;
> +		} else {
> +			dev_err(pdev->dev.parent,
> +				"Platform data or DT node not supplied\n");
> +			return -ENODEV;
> +		}
> +	}

The driver shouldn't need these to probe, it should be able to start in
read only mode with no configuration.

> +static int __init s2mpa01_pmic_init(void)
> +{
> +	return platform_driver_register(&s2mpa01_pmic_driver);
> +}
> +subsys_initcall(s2mpa01_pmic_init);

module_platform_driver().

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)