linux-kernel - Re: [PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c

Open Source and information security mailing list archives

Message-ID: <52CD4637.8010805@vmware.com>
Date:	Wed, 08 Jan 2014 13:36:07 +0100
From:	Thomas Hellstrom <thellstrom@...are.com>
To:	Josh Triplett <josh@...htriplett.org>
CC:	Jakob Bornecrantz <wallbraker@...il.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	DRI Development <dri-devel@...ts.freedesktop.org>,
	Rashika Kheria <rashika.kheria@...il.com>,
	Dave Airlie <airlied@...hat.com>, Rob Clark <rob@...com>
Subject: Re: [PATCH 82/85] drivers: gpu: Mark functions as static in vmwgfx_kms.c

On 01/07/2014 11:51 AM, Josh Triplett wrote:
> On Tue, Jan 07, 2014 at 11:21:12AM +0100, Jakob Bornecrantz wrote:
>> On Mon, Jan 6, 2014 at 5:48 PM, Rashika Kheria <rashika.kheria@...il.com> wrote:
>>> Mark functions as static because they are not used outside the file
>>> drm/vmwgfx/vmwgfx_kms.c.
>>>
>>> This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c:
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prototype for ‘vmw_clip_cliprects’ [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous prototype for ‘vmw_framebuffer_surface_destroy’ [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous prototype for ‘vmw_framebuffer_surface_dirty’ [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous prototype for ‘vmw_framebuffer_dmabuf_destroy’ [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous prototype for ‘vmw_framebuffer_dmabuf_dirty’ [-Wmissing-prototypes]
>>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous prototype for ‘vmw_du_update_layout’ [-Wmissing-prototypes]
>>>
>>> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
>>> Reviewed-by: Josh Triplett <josh@...htriplett.org>
>>> ---
>>>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |   12 ++++++------
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> This and patch 83, 84, 85 are
>> Reviewed-by: Jakob Bornecrantz <jakob@...are.com>
> Can you take them through your tree, or are you expecting them to follow
> another path?

I'll take them through vmwgfx-next. However, patch 83/85 conflicts
heavily with an internal vmwgfx patch series. If applicable, I'll apply
it after resolving those conflicts.

Thanks,

/Thomas

>
> - Josh Triplett
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives