linux-kernel - Re: [PATCH] video: mx3fb: Allow blocking during framebuffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52CD54A3.7040705@ti.com>
Date:	Wed, 8 Jan 2014 15:37:39 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Sascha Hauer <s.hauer@...gutronix.de>
CC:	<linux-fbdev@...r.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] video: mx3fb: Allow blocking during framebuffer allocation

On 2013-12-19 10:23, Sascha Hauer wrote:
> No need to allocate the framebuffer from the atomic pool, we are not
> in interrupt context. Adding GFP_KERNEL to the framebuffer allocation
> allows to use the much bigger CMA pool to allocate the framebuffer.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@...com>
> Cc: linux-fbdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/video/mx3fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
> index cfdb380..c882bec 100644
> --- a/drivers/video/mx3fb.c
> +++ b/drivers/video/mx3fb.c
> @@ -1263,7 +1263,7 @@ static int mx3fb_map_video_memory(struct fb_info *fbi, unsigned int mem_len,
>  
>  	fbi->screen_base = dma_alloc_writecombine(fbi->device,
>  						  mem_len,
> -						  &addr, GFP_DMA);
> +						  &addr, GFP_DMA | GFP_KERNEL);
>  
>  	if (!fbi->screen_base) {
>  		dev_err(fbi->device, "Cannot allocate %u bytes framebuffer memory\n",
> 

Thanks, queued for 3.14.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)