linux-kernel - Re: [PATCH] audit: correct a type mismatch in audit_syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140108200652.GA23577@madcap2.tricolour.ca>
Date:	Wed, 8 Jan 2014 15:06:52 -0500
From:	Richard Guy Briggs <rgb@...hat.com>
To:	AKASHI Takahiro <takahiro.akashi@...aro.org>
Cc:	viro@...iv.linux.org.uk, eparis@...hat.com, dsaxena@...aro.org,
	linux-audit@...hat.com, linux-kernel@...r.kernel.org,
	patches@...aro.org
Subject: Re: [PATCH] audit: correct a type mismatch in audit_syscall_exit()

On 13/12/25, AKASHI Takahiro wrote:
> audit_syscall_exit() saves a result of regs_return_value() in intermediate
> "int" variable and passes it to __audit_syscall_exit(), which expects its
> second argument as a "long" value.
> This will result in truncating the value returned by a system call and
> making a wrong audit record.
> I don't know why gcc compiler doesn't complain about this, but anyway it
> causes a problem at runtime on arm64 (and probably most 64-bit archs).
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org>

Thanks for catching this, Takakiro.

> ---
>  include/linux/audit.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/audit.h b/include/linux/audit.h
> index c49a312..3dcb3f0 100644
> --- a/include/linux/audit.h
> +++ b/include/linux/audit.h
> @@ -144,7 +144,7 @@ static inline void audit_syscall_exit(void *pt_regs)
>  {
>  	if (unlikely(current->audit_context)) {
>  		int success = is_syscall_success(pt_regs);
> -		int return_code = regs_return_value(pt_regs);
> +		long return_code = regs_return_value(pt_regs);
>  
>  		__audit_syscall_exit(success, return_code);
>  	}

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/