linux-kernel - Re: [char-misc 1/4] mei: do not run reset flow from the interrupt thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140108232410.GA11300@kroah.com>
Date:	Wed, 8 Jan 2014 15:24:10 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org,
	Alexander Usyskin <alexander.usyskin@...el.com>
Subject: Re: [char-misc 1/4] mei: do not run reset flow from the interrupt
 thread

On Wed, Jan 08, 2014 at 08:19:21PM +0200, Tomas Winkler wrote:
> This fixes a potential deadlock in case of a firmware
> initiated reset
> 
> mei_reset has a dialog with the interrupt thread hence
> it has to be run from an another work item
> 
> Most of the mei_resets were called from mei_hbm_dispatch
> which is called in interrupt thread context so this
> function underwent major revamp. The error code is
> propagated to the interrupt thread and if needed
> the reset is scheduled from there.
> 
> Cc: <stable@...r.kernel.org> 
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com>
> ---
>  drivers/misc/mei/hbm.c       | 200 +++++++++++++++++++++++++++----------------
>  drivers/misc/mei/hbm.h       |   6 +-
>  drivers/misc/mei/hw-me.c     |  32 ++++---
>  drivers/misc/mei/init.c      | 100 +++++++++++++---------
>  drivers/misc/mei/interrupt.c |   9 +-
>  drivers/misc/mei/mei_dev.h   |   1 +
>  6 files changed, 210 insertions(+), 138 deletions(-)

This is a _really_ big patch for a stable kernel tree.  Are you sure
it's needed there?  Please go read Documentation/stable_kernel_rules.txt
again.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/