linux-kernel - Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEPRUYo0r5YcRTYdgSNLqedVV4D0bsor7USBoxRRpBXRs7wpbw@mail.gmail.com>
Date:	Wed, 8 Jan 2014 15:38:49 -0800
From:	Christian Daudt <bcm@...thebug.org>
To:	Tim Kryger <tim.kryger@...aro.org>
Cc:	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Broadcom Kernel Feedback List 
	<bcm-kernel-feedback-list@...adcom.com>,
	Device Tree List <devicetree@...r.kernel.org>,
	Linux Arm Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linaro Patches <patches@...aro.org>
Subject: Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO

On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger <tim.kryger@...aro.org> wrote:
> The board schematic states that the "SD_CARD_DET_N gets pulled to GND
> when card is inserted" so the polarity has been updated to active low.
>
> Polarity is now specified with a GPIO define instead of a magic number.
>
> Signed-off-by: Tim Kryger <tim.kryger@...aro.org>
> Reviewed-by: Matt Porter <matt.porter@...aro.org>
> ---
>  arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
> index 08e47c2..27dd110 100644
> --- a/arch/arm/boot/dts/bcm28155-ap.dts
> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
> @@ -13,6 +13,8 @@
>
>  /dts-v1/;
>
> +#include <dt-bindings/gpio/gpio.h>
> +
>  #include "bcm11351.dtsi"
>
>  / {
> @@ -40,7 +42,7 @@
>
>         sdio4: sdio@...b0000 {
>                 max-frequency = <48000000>;
> -               cd-gpios = <&gpio 14 0>;
> +               cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
>                 status = "okay";
>         };
>  };
> --
> 1.8.0.1
>
Tim,
 Does bcm11351-brt not also suffer from the same bug? If it does can
you pls update the patch to also fix it?

 Thanks,
   csd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/