linux-kernel - Re: [PATCH 1/2] Staging: lustre: Fix line length exceeding 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140108235522.GB20259@kroah.com>
Date:	Wed, 8 Jan 2014 15:55:22 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	MonamAgarwal <monamagarwal123@...il.com>,
	devel@...verdev.osuosl.org, andreas.dilger@...el.com,
	peter.p.waskiewicz.jr@...el.com, linux-kernel@...r.kernel.org,
	rashika.kheria@...il.com
Subject: Re: [PATCH 1/2] Staging: lustre: Fix line length exceeding 80
 characters

On Sun, Jan 05, 2014 at 12:30:51PM -0800, Joe Perches wrote:
> On Mon, 2014-01-06 at 01:41 +0530, MonamAgarwal wrote:
> > This patch fixes the following checkpatch.pl warning in
> > lustre/ldlm/interval_tree.c
> > WARNING: line over 80 characters in the file
> []
> > diff --git a/drivers/staging/lustre/lustre/ldlm/interval_tree.c b/drivers/staging/lustre/lustre/ldlm/interval_tree.c
> []
> > @@ -429,7 +429,8 @@ static void interval_erase_color(struct interval_node *node,
> >  					struct interval_node *o_left;
> >  					o_left = tmp->in_left;
> >  					if (o_left)
> > -						o_left->in_color = INTERVAL_BLACK;
> > +						o_left->in_color =
> > +							INTERVAL_BLACK;
> 
> Likely this function would be better off with some
> refactoring instead of straining to fit 80 cols.

I agree, if you are doing things like this, that's a huge hint that the
code needs fixing.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/