linux-kernel - Re: [PATCH 3/6 v2] crypto:s5p-sss: Add support for SSS module on Exynos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Jan 2014 15:02:48 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>
Cc:	linux-crypto@...r.kernel.org,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, vzapolskiy@...il.com,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Tomasz Figa <tomasz.figa@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 3/6 v2] crypto:s5p-sss: Add support for SSS module on Exynos

Hi Naveen,

On 9 January 2014 10:29, Naveen Krishna Chatradhi <ch.naveen@...sung.com> wrote:
> This patch adds new compatible and varient to support the SSS module
> on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250) for which
> 1. AES register are at an offset of 0x200 and
> 2. hash interrupt is not available
>
> Signed-off-by: Naveen Krishna Ch <ch.naveen@...sung.com>
> CC: Herbert Xu <herbert@...dor.apana.org.au>
> CC: David S. Miller <davem@...emloft.net>
> CC: Vladimir Zapolskiy <vzapolskiy@...il.com>
> TO: <linux-crypto@...r.kernel.org>
> CC: <linux-samsung-soc@...r.kernel.org>
> ---
> Changes since v1:
> 1. Used varient struct
> 2. Added description in Documentation
>
>  .../devicetree/bindings/crypto/samsung-sss.txt     |   20 +++++++++
>  drivers/crypto/s5p-sss.c                           |   43 ++++++++++++++------
>  2 files changed, 51 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/samsung-sss.txt b/Documentation/devicetree/bindings/crypto/samsung-sss.txt
> index 0e45b0d..4531da2 100644
> --- a/Documentation/devicetree/bindings/crypto/samsung-sss.txt
> +++ b/Documentation/devicetree/bindings/crypto/samsung-sss.txt
> @@ -8,13 +8,33 @@ The SSS module in S5PV210 SoC supports the following:
>  -- SHA-1/SHA-256/MD5/HMAC (SHA-1/SHA-256/MD5)/PRNG
>  -- PRNG: Pseudo Random Number Generator
>
> +The SSS module in Exynos4 (Exynos4210) and
> +Exynos5 (Exynos5420 and Exynos5250) SoCs
> +supports the following also:
> +-- ARCFOUR (ARC4)
> +-- True Random Number Generator (TRNG)
> +-- Secure Key Manager
> +
>  Required properties:
>
>  - compatible : Should contain entries for this and backward compatible
>    SSS versions:
>    - "samsung,s5p-secss" for S5PV210 SoC.
> +  - "samsung,exynos-secss" for Exynos4210, Exynos5250 and Exynos5420 SoCs.

Shouldn't the compatible string be more specific with the name of the
first SoC that had this IP?

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/