linux-kernel - Re: [PATCH 2/5] ARM: kprobes-test: use <asm/opcodes.h> for instruction accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1389265491.4041.6.camel@linaro1.home>
Date:	Thu, 09 Jan 2014 11:04:51 +0000
From:	"Jon Medhurst (Tixy)" <tixy@...aro.org>
To:	Taras Kondratiuk <taras.kondratiuk@...aro.org>
Cc:	Russell King <linux@....linux.org.uk>,
	Linaro Kernel <linaro-kernel@...ts.linaro.org>,
	Patch Tracking <patches@...aro.org>,
	open list <linux-kernel@...r.kernel.org>,
	Ben Dooks <ben.dooks@...ethink.co.uk>,
	Linaro Networking <linaro-networking@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/5] ARM: kprobes-test: use <asm/opcodes.h> for
 instruction accesses

On Thu, 2014-01-09 at 12:54 +0200, Taras Kondratiuk wrote:
> On 3 January 2014 17:53, Jon Medhurst (Tixy) <tixy@...aro.org> wrote:
> > On Mon, 2013-12-23 at 18:19 +0200, Taras Kondratiuk wrote:
> >> From: Ben Dooks <ben.dooks@...ethink.co.uk>
> >>
> >> Ensure we read instructions in the correct endian-ness by using
> >> the <asm/opcodes.h> helper to transform them as necessary.
> >>
> >> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> >> [taras.kondratiuk@...aro.org: fix next_instruction() function]
> >> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@...aro.org>
> >> ---
> >
> > Apart from the spurious line removal (see below) then:
> >
> > Acked-by: Jon Medhurst <tixy@...aro.org>
> >
> > and you can include an ACK for the other patches in this series too.
> >
> > Thanks.
> 
> >> @@ -1593,7 +1594,6 @@ static int run_test_cases(void (*tests)(void), const union decode_item *table)
> >>       return 0;
> >>  }
> >>
> >> -
> >
> > I know the above blank line isn't needed but I believe the convention is
> > to avoid doing unrelated white-space clean-ups in patches.
> 
> Right, I will remove it.
> Should this series go through Russell's patch tracking system or it
> can be pulled
> to some tree?

I would assume as a pull request sent to Russell using the email alias
he uses for these things: linux+pull@....linux.org.uk I'm sure he's
shout up if I'm wrong...

-- 
Tixy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/