linux-kernel - Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140109120351.GA25423@aepfle.de>
Date:	Thu, 9 Jan 2014 13:03:51 +0100
From:	Olaf Hering <olaf@...fle.de>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, apw@...onical.com,
	jasowang@...hat.com
Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

On Wed, Jan 08, K. Y. Srinivasan wrote:

> +++ b/tools/hv/hv_fcopy_daemon.c

> +		len = pread(fcopy_fd, buffer, (4096 * 2), 0);
> +
> +		if (len <= 0) {
> +			syslog(LOG_ERR, "Read error: %s\n", strerror(errno));
> +			continue;

This could flood syslog. I think the error should be logged just once.
Maybe like this:

        if (len <=0) {
                if (!error) {
                        syslog(...);
                        error = HV_ERROR_NOT_SUPPORTED;
                }
                continue;
        }

> +		}
> +		in_msg = (struct hv_fcopy_hdr *)buffer;
> +
> +		switch (in_msg->operation) {
> +		case START_FILE_COPY:
> +			error = hv_start_fcopy((struct hv_start_fcopy *)in_msg);

Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/