linux-kernel - [PATCH Trivial] intel-iommu: check return value of device_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Jan 2014 09:58:42 +0800
From:	ethan zhao <ethan.zhao@...cle.com>
To:	joro@...tes.org, dwmw2@...radead.org, yinghai@...nel.org,
	bhelgaas@...gle.com, jiang.liu@...ux.intel.com
CC:	iommu@...ts.linux-foundation.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH Trivial] intel-iommu: check return value of device_to_iommu()
 before using it

in function iommu_support_dev_iotlb(),return value of device_to_iommu()
is used without checking, this could cause NULL pointer issue.

this patch is for v3.12.6

Signed-off-by: Ethan Zhao <ethan.zhao@...cle.com>
---
  drivers/iommu/intel-iommu.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 40203ad..5b4531a 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -1105,6 +1105,8 @@ static struct device_domain_info 
*iommu_support_dev_iotlb(
      struct device_domain_info *info;
      struct intel_iommu *iommu = device_to_iommu(segment, bus, devfn);

+    if (!iommu)
+        return NULL;
      if (!ecap_dev_iotlb_support(iommu->ecap))
          return NULL;

-- 
1.7.1


View attachment "0001-intel-iommu-check-return-value-of-device_to_iommu-be.patch" of type "text/x-patch" (1003 bytes)