linux-kernel - Re: [PATCH 2/2] intel_idle: close avn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Jan 2014 14:31:45 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
Cc:	" Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	" H. Peter Anvin" <hpa@...ux.intel.com>,
	Len Brown <len.brown@...el.com>, Len Brown <lenb@...nel.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] intel_idle: close avn_cstates array with correct marker

On Thursday, January 09, 2014 03:30:27 PM Jiang Liu wrote:
> Close avn_cstates array with correct marker to avoid overflow
> in function intel_idle_cpu_init().
> 
> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
> Cc: <stable@...r.kernel.org> # 3.13

Why did you mark it for 3.13-stable?  3.13 hasn't been released yet, so this
can be pushed for 3.13 still.

Is the problem present in 3.13-rc?  If so, has it been introduced by any
recent commits or was it there before?  In which case, do we need this patch
in stable as well?

Rafael


> ---
>  drivers/idle/intel_idle.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 6f456f0..797ed29 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -329,7 +329,7 @@ static struct cpuidle_state atom_cstates[] = {
>  	{
>  		.enter = NULL }
>  };
> -static struct cpuidle_state avn_cstates[] __initdata = {
> +static struct cpuidle_state avn_cstates[] = {
>  	{
>  		.name = "C1-AVN",
>  		.desc = "MWAIT 0x00",
> @@ -344,6 +344,8 @@ static struct cpuidle_state avn_cstates[] __initdata = {
>  		.exit_latency = 15,
>  		.target_residency = 45,
>  		.enter = &intel_idle },
> +	{
> +		.enter = NULL }
>  };
>  
>  /**
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/