linux-kernel - Re: [PATCH] spi: Check conflicting CS based on spi->chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140109140646.GT31886@sirena.org.uk>
Date:	Thu, 9 Jan 2014 14:06:46 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-spi@...r.kernel.org,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: Check conflicting CS based on spi->chip_select
 instead of device name

On Thu, Jan 09, 2014 at 03:23:55PM +0200, Mika Westerberg wrote:

> In case of a buggy BIOS that lists multiple SPI devices sharing the same
> chip select (even though they should use different) the current code fails
> to detect that and allows the devices to be added to the bus.

This actually also points out another issue - if we have two instances
of a device on different buses they could end up with the same
dev_name() if they have the same chip select.  Hrm.

I'll apply this but we'll probably need to do something about such
conflicts at some point.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)