linux-kernel - Re: [alsa-devel] [PATCH] ASoC: wm8804: Allow fine-grained control of the PLL generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140109172350.GD12858@sirena.org.uk>
Date:	Thu, 9 Jan 2014 17:23:50 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Trent Piepho <tpiepho@...il.com>
Cc:	Daniel Matuschek <daniel@...uschek.net>,
	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	Dimitris.Papastamos@...fsonmicro.com, Takashi Iwai <tiwai@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	devicetree-discuss@...ts.ozlabs.org,
	patches@...nsource.wolfsonmicro.com,
	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: wm8804: Allow fine-grained control of
 the PLL generation

On Thu, Jan 09, 2014 at 09:14:07AM -0800, Trent Piepho wrote:
> On Thu, Jan 9, 2014 at 7:29 AM, Daniel Matuschek <daniel@...uschek.net> wrote:

Daniel, please take more care with the CC lists when posting things -
there's nothing to do with device tree in this patch but you've CCed the
DT list and some DT people  wich means more noise in their mailbox.

> Why does it need to be an option?  If 256x is better, then why not
> always use it?  Maybe the code to select the divisor should be better?

It's typically a power/performance tradeoff, though for this part I
can't see anyone caring about power.

> Since it stops at the first divisor that works, won't it always use
> mclkdiv=1?  If mclkdiv=0 is better, why not just list those first/only
> in the table so they get used?

This seems like the best idea.  I suspect the table just got typed in
from the datasheet.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)