linux-kernel - Re: [PATCH] ASoC: simple-card: fix a bug where cinfo will be NULL before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140109173739.GH12858@sirena.org.uk>
Date:	Thu, 9 Jan 2014 17:37:39 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: simple-card: fix a bug where cinfo will be NULL
 before using it

On Thu, Jan 09, 2014 at 05:19:08PM +0800, Xiubo Li wrote:

>  	} else {
> -		cinfo->snd_card.dev = &pdev->dev;
>  		cinfo = pdev->dev.platform_data;
> +		cinfo->snd_card.dev = &pdev->dev;
>  	}

I've applied this since not crashing is good but it's a bug to be
writing to the platform data at all, it should be constant.  If it needs
to be written to a copy should be being used.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)