linux-kernel - Re: [PATCH] pci/iov: VFs are never multifunction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo4Asnx4JiZvppZLUzxmVymz0t-fHXRFMr81-Qz31XyR+g@mail.gmail.com>
Date:	Thu, 9 Jan 2014 11:08:38 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Alex Williamson <alex.williamson@...hat.com>
Cc:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	sathya.perla@...lex.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	ajit.khaparde@...lex.com, Don Dutile <ddutile@...hat.com>,
	subbu.seetharaman@...lex.com, Myron Stowe <myron.stowe@...hat.com>
Subject: Re: [PATCH] pci/iov: VFs are never multifunction

On Thu, Jan 9, 2014 at 8:36 AM, Alex Williamson
<alex.williamson@...hat.com> wrote:
> Per the SR-IOV spec rev 1.1:
>
> 3.4.1.9 Header Type (Offset 0Eh)
>
> "... For VFs, this register must be RO Zero."
>
> Unfortunately some devices get this wrong, ex. Emulex OneConnect 10Gb
> NIC.  When they do it makes us handle ACS testing and therefore IOMMU
> groups as if they were actual multifunction devices and require ACS
> capabilities to make sure there's no peer-to-peer between functions.
> VFs are never traditional multifunction devices, so simply clear this
> bit before we get any further into setup.

This seems reasonable.  Do you have "lspci -vvxxxx" output for this
device?  I'd like to save it for future reference.

> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
> ---
>  drivers/pci/iov.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 1fe2d6f..e2fbb67 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -84,6 +84,7 @@ static int virtfn_add(struct pci_dev *dev, int id, int reset)
>         virtfn->dev.parent = dev->dev.parent;
>         virtfn->physfn = pci_dev_get(dev);
>         virtfn->is_virtfn = 1;
> +       virtfn->multifunction = 0;
>
>         for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
>                 res = dev->resource + PCI_IOV_RESOURCES + i;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/